Skip to content

Sample / 0.74.1 → 0.75.5#269

Merged
markmur merged 10 commits into
mainfrom
0.75.5
Aug 20, 2025
Merged

Sample / 0.74.1 → 0.75.5#269
markmur merged 10 commits into
mainfrom
0.75.5

Conversation

@markmur
Copy link
Copy Markdown
Contributor

@markmur markmur commented Aug 18, 2025

What changes are you making?

Upgrades React Native from 0.74.1 to 0.75.5 in the sample app, based on https://react-native-community.github.io/upgrade-helper/?from=0.74.1&to=0.75.5&package=com.shopify.checkoutkitreactnative&name=ReactNative


PR Checklist

Important

Releasing a new version of the kit?

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@markmur markmur self-assigned this Aug 18, 2025
@markmur markmur requested a review from a team as a code owner August 18, 2025 10:30
@markmur markmur changed the title Sample / 0.75.5 Sample / 0.74.1 → 0.75.5 Aug 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 18, 2025

Coverage Report

Lines Statements Branches Functions
Coverage: 100%
100% (120/120) 98.03% (50/51) 100% (41/41)

@markmur markmur force-pushed the 0.75.5 branch 6 times, most recently from a55f390 to be609ba Compare August 18, 2025 19:32
@markmur markmur enabled auto-merge (squash) August 19, 2025 10:30
@markmur markmur disabled auto-merge August 19, 2025 16:32
Comment thread sample/android/app/src/main/AndroidManifest.template.xml
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed to test iOS & Android (after manually tweaking the manifest locally) and both look good - just need to change the manifest so it doesn't error

Comment thread sample/android/app/src/main/AndroidManifest.template.xml
@markmur
Copy link
Copy Markdown
Contributor Author

markmur commented Aug 20, 2025

@kieran-osgood-shopify you sure it's not something to do with your local setup?

The tests were failing in CI and I'm having issues locally without the quotes, so I've reverted the change.

Can you try deleting the AndroidManifest.xml file and running yarn sample test:android --no-daemon from root or ./gradlew clean generateAndroidManifestFromTemplate from sample/android?

@markmur markmur enabled auto-merge (squash) August 20, 2025 12:53
@markmur markmur merged commit 44433e5 into main Aug 20, 2025
8 checks passed
@markmur markmur deleted the 0.75.5 branch August 20, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants